Prevent artifact locations that are directories from being opened as zip files #182
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This pull request fixes a bug where the oss-licenses-plugin will attempt to create a ZipFile from a directory, resulting in a FileNotFoundException.
Such a situation may occur when:
When this happens, both the transformed dependency and the untransformed dependency will be listed in the
dependencies.json
file. For example:Actual dependency
Transformed dependency, which is a directory named xyz.aar
For the most part, the oss-licenses-plugin seems to handle the directory case well, as it will usually just detect that no POM file is present and ignore it. However, in the case above,
isGoogleServices
will return true and we'll end up inaddGooglePlayServiceLicenses
, which tries to open the directory as a zip file.This pull request makes sure the method just returns when the artifactFile is a directory. License information will still be picked up when the actual artifactFile is processed.
Best Regards,
Jago